Add logic to avoid conficts between the enum class and variants class names#1056
Merged
sugmanue merged 2 commits intosmithy-lang:mainfrom Mar 9, 2026
Merged
Conversation
rhernandez35
approved these changes
Mar 9, 2026
Contributor
rhernandez35
left a comment
rhernandez35
left a comment
There was a problem hiding this comment.
Good catch, I wonder how many other instances of this problem we have in the generator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
If an enum has a name that ends of the form Type and a variant that has the name a conflict of names is created: the inner class representing the variant will have the same name of the enum itself, e.g.,
To avoid the conflict, we changed the logic to add another suffix "Value" to the variant class name.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.